chore(color-eyre): Set color-eyre dependency on eyre via path. #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pksunkara
reviewed
Aug 22, 2024
color-eyre/Cargo.toml
Outdated
| @@ -18,7 +18,7 @@ issue-url = ["url"] | |||
| track-caller = [] | |||
|
|
|||
| [dependencies] | |||
| eyre = "0.6.1" | |||
| eyre = { path = "../eyre" } | |||
There was a problem hiding this comment.
Please have a version too in here. That way, we get best of both worlds.
There was a problem hiding this comment.
Thank you @pksunkara — I added version to this dependency description as "1.0.0", is it okay?
There was a problem hiding this comment.
Yes, but please reset the lockfile to remove unneeded upgrades. And then run cargo update to update eyre related changes.
There was a problem hiding this comment.
That's done @pksunkara
pksunkara
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Good day, dear eyre contributors.
I really like to use eyre in all my projects. Right now I use master to stay on 1.0 version.
Unfortunately when I want to start using color-eyre the same way it conflicts with eyre, because it uses 0.6.1 version.
What this PR addresses is to temporary set color-eyre -> eyre dependency via path, not a version, until 1.0 will be released.
If it's not something you want to have in the codebase, just please let me know, I will then switch to my fork and keep it sync with the main repo. Thank you in advance, you are awesome! 💜