Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(color-eyre): add no-export-owo-colors feature #188

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

0xAdk
Copy link

@0xAdk 0xAdk commented Jul 31, 2024

Reexporting owo-colors causes rust-analzyer's code completion to fill with many auto-use suggestions for the owo-colors::OwoColorize trait.

This feature allows users to opt-out of reexporting owo-colors.

see eyre-rs/color-eyre#109

@0xAdk
Copy link
Author

0xAdk commented Jul 31, 2024

Sorry since I don't use features often this didn't occur to me. Would this be a breaking change for anyone with default-features = false? Maybe a non-default no-export-owo-colors (I'm sure there is a better name) feature would be better.

Reexporting `owo-colors` causes rust-analzyer's code completion to fill
with many auto-use suggestions for the `owo-colors::OwoColorize` trait.

This feature allows users to opt-out of reexporting `owo-colors`.
@0xAdk 0xAdk changed the title feat(color-eyre): add default export-owo-colors feature feat(color-eyre): add no-export-owo-colors feature Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant