-
-
Notifications
You must be signed in to change notification settings - Fork 572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set CREATE_NO_WINDOW
flag when executing Git hooks
#2371
Conversation
I've tested this functionality using a dev build of GitButler with the |
Thanks for the contribution! Can you fix the ci issues? |
Sure thing! |
@extrawurst that should fix it, I had forgotten to ensure this was a noop when you're not on Windows |
@extrawurst out of curiosity, do you have an idea of when the next release will be? Also, I believe the CI workflow requires your approval again. |
@icorbrey since this is a separate crate i can cut a release as soon as this is merged |
released git2-hooks |
This Pull Request makes changes to accommodate GUI functionality in GitButler (see: gitbutlerapp/gitbutler#4982).
It changes the following:
CREATE_NO_WINDOW
flag when executing Git hooks on Windows.I followed the checklist:
make check
without errors