Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set CREATE_NO_WINDOW flag when executing Git hooks #2371

Merged
merged 5 commits into from
Sep 30, 2024

Conversation

icorbrey
Copy link
Contributor

@icorbrey icorbrey commented Sep 27, 2024

This Pull Request makes changes to accommodate GUI functionality in GitButler (see: gitbutlerapp/gitbutler#4982).

It changes the following:

  • Set the CREATE_NO_WINDOW flag when executing Git hooks on Windows.

I followed the checklist:

  • I added unittests
  • I ran make check without errors
  • I tested the overall application
  • I added an appropriate item to the changelog

@icorbrey icorbrey marked this pull request as ready for review September 27, 2024 19:17
@icorbrey
Copy link
Contributor Author

I've tested this functionality using a dev build of GitButler with the git2-hooks dependency pointed at my local copy of gitui. Please let me know if I need to do anything else to get this merged, it bothers me when using GitButler with Lefthook and I'd like to be able to get it fixed!

@extrawurst
Copy link
Owner

Thanks for the contribution! Can you fix the ci issues?

@icorbrey
Copy link
Contributor Author

Sure thing!

@icorbrey
Copy link
Contributor Author

@extrawurst that should fix it, I had forgotten to ensure this was a noop when you're not on Windows

@icorbrey
Copy link
Contributor Author

@extrawurst out of curiosity, do you have an idea of when the next release will be? Also, I believe the CI workflow requires your approval again.

@extrawurst
Copy link
Owner

@icorbrey since this is a separate crate i can cut a release as soon as this is merged

@extrawurst extrawurst merged commit d98171b into extrawurst:master Sep 30, 2024
21 checks passed
@extrawurst
Copy link
Owner

released git2-hooks v0.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants