Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update migration guide #1610

Merged
merged 8 commits into from
Oct 6, 2024
Merged

Conversation

bjohansebas
Copy link
Member

@bjohansebas bjohansebas commented Sep 12, 2024

Several undocumented changes have been added in version 5, as referenced in #1479 (comment):

Copy link

netlify bot commented Sep 12, 2024

Deploy Preview for expressjscom-preview ready!

Name Link
🔨 Latest commit 5fd7a0d
🔍 Latest deploy log https://app.netlify.com/sites/expressjscom-preview/deploys/66ea03eeaad7a1000834c378
😎 Deploy Preview https://deploy-preview-1610--expressjscom-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bjohansebas bjohansebas added the 5.x Docs for 5.x version label Sep 12, 2024
@bjohansebas bjohansebas marked this pull request as ready for review September 13, 2024 01:08
@bjohansebas bjohansebas requested a review from a team September 13, 2024 01:08
@wesleytodd
Copy link
Member

Thanks for the ping! I hadn't seen this until now. I am working on a blog post for the v5 release now, and it would be awesome if we could land this before so I can link to it. I also ping'd @danieldelcore who did some codemod work, would be good if we can team up for this.

@bjohansebas
Copy link
Member Author

@wesleytodd It would be great to add codemod, it would make the transition to the new version much easier. I can help with that.

en/guide/migrating-5.md Outdated Show resolved Hide resolved
@bjohansebas bjohansebas requested a review from a team September 16, 2024 21:58
@bjohansebas
Copy link
Member Author

cc/: @expressjs/express-tc @expressjs/triagers

@crandmck
Copy link
Member

LGTM. I added @UlisesGascon specifically as a reviewer, since this is based on his comment in. #1479 (comment).

@UlisesGascon If you approve, please go ahead and merge this so it doesn't have to wait on me.

@UlisesGascon
Copy link
Member

We can always make more changes in the future. I will merge it now 👍

@UlisesGascon UlisesGascon merged commit 5bbc22a into expressjs:gh-pages Oct 6, 2024
8 of 9 checks passed
@bjohansebas bjohansebas deleted the migration-v5 branch October 6, 2024 16:08
chrisdel101 pushed a commit to chrisdel101/expressjs.com that referenced this pull request Nov 3, 2024
* add `res.query` and `res.redirect`
* add `express.urlencoded` and `req.body`
* add `res.clearCookie` and `res.status`
* update introduction page
* add `res.redirect('back')` and `res.location('back')`
* bring changes from expressjs#1317
* add `brotli` support
* adapt router matching syntax
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5.x Docs for 5.x version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants