Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add additional externals for lottie-react-native #597

Merged
merged 4 commits into from
Aug 1, 2024

Conversation

byCedric
Copy link
Member

@byCedric byCedric commented Aug 1, 2024

Why

This fixes [email protected] for Snack.

How

  • Added Snackager bundling test
  • Marked react-native/Libraries/NativeComponent/ViewConfigIgnore as external
  • Marked react-native/Libraries/ReactNative/RendererProxy as external
  • Added alias for react-native/Libraries/NativeComponent/ViewConfigIgnore in runtime
  • Added alias for react-native/Libraries/ReactNative/RendererProxy in runtime

Test Plan

See CI

@byCedric byCedric merged commit fe41401 into main Aug 1, 2024
19 checks passed
@byCedric byCedric deleted the @bycedric/fix/lottie branch August 1, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant