-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: add monorepo tooling to minimize maintenance #464
Conversation
903f302
to
ad7dd0e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
basically looks good to me. good to learn the turbo prune --docker
.
didn't see any big problem in this pr, just have to deploy and we will know.
@Kudo We definitely need to just try it in deployment, that's why Snack staging is already running this image 😄 And so far, its looking good. Edit: both Website and Snackager are now running these Dockerfiles 👍 It's also insane to me how much build cache we still shipped with the website image. It's now reduced by a factor of 3.9x 🙈 |
5453a3b
to
5b2cc3f
Compare
ad7dd0e
to
e07927d
Compare
1ee20fa
to
368f560
Compare
a85498b
to
8c65276
Compare
8c65276
to
044d5dc
Compare
97608e8
to
1c9663d
Compare
…imize final image This also gets rid of the hardcoded paths. Whenever dependencies in the monorepo are changed, we don't need to update the Dockerfile, as it automatically includes or excludes the changed workspaces.
…mize final image
1814169
to
cda56a4
Compare
Why
This is another attempt to implement proper monorepo tooling to minimize maintenance as much as possible.
How
turbo
as monorepo toolturbo
to remove unused workspaces, which auto-updates once they are added/removed.Docker sizes
Test Plan
Since this is a big change, have to fully test this on staging first.