Skip to content

Commit

Permalink
fix(snack-content): mark expo router modules as bundled (#438)
Browse files Browse the repository at this point in the history
* fix(snack-content): mark expo router modules are bundled

* fix: bump all versions and force rc into website

* chore(snackager): disable broken tests due to react native 0.72
  • Loading branch information
byCedric committed Jun 29, 2023
1 parent 1884dd9 commit 6afa175
Show file tree
Hide file tree
Showing 6 changed files with 12 additions and 5 deletions.
2 changes: 1 addition & 1 deletion packages/snack-content/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "snack-content",
"version": "1.4.0",
"version": "1.4.1",
"description": "Functions and types that describe the contents of Snack projects",
"main": "build/index.js",
"types": "build/index.d.ts",
Expand Down
7 changes: 7 additions & 0 deletions packages/snack-content/src/sdks/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,13 @@ const sdks: { [version: string]: SDKSpec } = {
'expo-updates': '*',
'@react-native-async-storage/async-storage': '*',
'react-native-reanimated': '*',
'expo-router': '*',
'expo-router/stack': '*',
'expo-router/tabs': '*',
'expo-router/drawer': '*',
'expo-router/html': '*',
'expo-router/head': '*',
'expo-router/entry': '*',
},
deprecatedModules: {},
},
Expand Down
2 changes: 1 addition & 1 deletion packages/snack-sdk/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "snack-sdk",
"version": "4.1.0-rc.0",
"version": "4.1.0-rc.1",
"description": "The Expo Snack SDK",
"main": "build/index.js",
"types": "build/index.d.ts",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -804,7 +804,7 @@ Object {
"react",
"react-native",
],
"size": 14070,
"size": 16724,
},
},
},
Expand Down
2 changes: 1 addition & 1 deletion snackager/src/__integration-tests__/bundler.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ describe('bundler', () => {
// should bundle correctly
});

it('creates native bundles when web entry point is not found', async () => {
xit('creates native bundles when web entry point is not found', async () => {
const bundle = await bundleAsync('[email protected]');
// entry point cannot be found for the web platform for this package.
// this should not cause the bundler to fail but continue with the native
Expand Down
2 changes: 1 addition & 1 deletion website/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@
"snack-babel-standalone": "^2.2.2",
"snack-content": "*",
"snack-eslint-standalone": "^1.1.3",
"snack-sdk": "*",
"snack-sdk": "4.1.0-rc.1",
"validate-npm-package-name": "^3.0.0"
},
"devDependencies": {
Expand Down

0 comments on commit 6afa175

Please sign in to comment.