Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement connections pool #23

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Kryvchun
Copy link

@Kryvchun Kryvchun commented Jun 24, 2022

  1. Implement connections pool
  2. Add base tests
  3. Test connection closing

Closes #11
Relates to #14

Changes are not breaking.

@Kryvchun Kryvchun changed the title Support conns pool Implement connections pool Jun 24, 2022
@Kryvchun Kryvchun changed the title Implement connections pool feat: implement connections pool Jun 29, 2022
@Kryvchun
Copy link
Author

@remicaumette Can you check it, please?

sonic/control.go Outdated Show resolved Hide resolved
sonic/control.go Outdated Show resolved Hide resolved
@alexisvisco
Copy link
Member

Hi, I am looking at it right now, i am sorry for the late reply

@anbraten
Copy link

anbraten commented Dec 26, 2022

This should also add thread safety, right? So the readme part about it could be updated?

@hedhyw
Copy link

hedhyw commented Dec 26, 2022

This should also add thread safety, right? So the readme part about it could be updated?

Updated

@charandas
Copy link

@alexisvisco Is there a plan to getting this merged? It seems the PR author is maintaining the fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bulk functions not work as expected with more than 1 goroutines
6 participants