Support for PyMC >= 5 #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
testval is deprecated now
… for utils.eval_in_model() Bounded variables are transformed by PyMC, which has implications for rvs_to_values I think Lists of variables are handled differently than single variables by utils.Evaluator
…_rvs_by_values()` These should be equivalent. `pymc.pytensorf.rvs_to_value_vars()` requires extra argument, but the model method fills them automatically.
|
LGTM - thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
After playing with PyMC >= 5 for exoplanet-core (exoplanet-dev/exoplanet-core#89), I thought I'd give this one a try.
Most changes boil down to replacing
aesarawithpytensor. I also updated sometestvalarguments toinitval.One somewhat important change is that
pm.pytensorf.rvs_to_value_vars()was deprecated with a warning, so I replaced it withpymc.Model().replace_rvs_by_values(), which is equivalent but requires the model context. Thepm.pytensorf.replace_rvs_by_values()requires extra keyword arguments which are passed automatically by the model method.Also, the
isortpre-commit hook failed so I updated the version (ref: PyCQA/isort#2108)