Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant lazy_static and once_cell #143

Merged
merged 1 commit into from
Aug 4, 2024
Merged

Conversation

senekor
Copy link
Contributor

@senekor senekor commented Aug 3, 2024

As of Rust 1.80, the functionality of these two crates has been stabilized in the standard library.

See https://blog.rust-lang.org/2024/07/25/Rust-1.80.0.html#lazycell-and-lazylock

As of Rust 1.80, the functionality of these two crates has been stabilized
in the standard library.

See https://blog.rust-lang.org/2024/07/25/Rust-1.80.0.html#lazycell-and-lazylock
@senekor senekor requested a review from a team as a code owner August 3, 2024 16:49
@senekor
Copy link
Contributor Author

senekor commented Aug 3, 2024

This is will break many solutions. For example, lazy_static was very useful for robot-name. There are two reasons I think it's worth it:

  • We cannot guarantee backwards compatibility for the libraries included in the test runner anyway. Bumping the major version of a crate could already break solutions. Including multiple major versions of the same library is infeasible since many libraries are not 1.0 and have semver-breaking changes often.
  • The community solutions are supposed to show "how it's done". Using lazy_static is not "how it's done" anymore. Hiding these solutions could be a net positive.

@senekor senekor merged commit fa2c1f1 into main Aug 4, 2024
2 checks passed
@senekor senekor deleted the remo/szuylpporkpx branch August 4, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants