Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prerequisites for practice exercises #1964

Merged
merged 4 commits into from
Oct 29, 2022

Conversation

TomPradat
Copy link
Contributor

@TomPradat TomPradat commented Oct 25, 2022

Could I please have an hacktoberfest label 🙏 ?

This solves 4 exercises in the issue #984

@github-actions
Copy link
Contributor

Dear TomPradat

Thank you for contributing to the JavaScript track on Exercism! 💙
You will see some automated feedback below 🤖. It would be great if you can make sure your PR covers those points. This will save your reviewer some time and your change can be merged quicker.

  • ✍️ If your PR is not related to an existing issue (and is not self-explaining like a typo fix), please make sure the description explains why the change you made is necessary.

  • 🔤 If your PR fixes an easy to identify typo, if would be great if you could check for that typo in the whole repo. For example, if you found Unicdoe, use "replace all" in your editor (or command line magic) to fix it consistently.

Dear Reviewer/Maintainer

  • 📏 Make sure you set the appropriate x:size label for the PR. (This also works after merging, in case you forgot about it.)

  • 🔍 Don't be too nit-picky. If the PR is a clear improvement compared to the status quo, it should be approved as clear signal this is good to be merged even if the minor comments you might have are not addressed by the contributor. Further improvement ideas can be captured in issues (if important enough) and implemented via additional PRs.

  • 🤔 After reviewing the diff in the "Files changed" section, take a moment to think about whether there are changes missing from the diff. Does something need to be adjusted in other places so the code or content stays consistent?

Automated comment created by PR Commenter 🤖.

Comment on lines +827 to +832
"prerequisites": [
"strings",
"arrays",
"conditionals-switch",
"for-loops"
],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is my solution : https://exercism.org/tracks/javascript/exercises/matching-brackets/solutions/TomPradat

I've seen many solutions with conditional switches and I prefer it to regexps ones. Also I've added arrays because I think this is good exercise for 'stack' type solutions

Comment on lines +870 to +877
"prerequisites": [
"arrays",
"strings",
"errors",
"classes",
"conditionals",
"array-transformations"
],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SleeplessByte SleeplessByte added hacktoberfest Hacktoberfest issues! Everyone allowed <3 hacktoberfest-accepted Opt-in to hacktoberfest labels Oct 26, 2022
Comment on lines +919 to +925
"prerequisites": [
"arrays",
"strings",
"for-loops",
"array-analysis",
"template-strings"
],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -922,7 +940,7 @@
"name": "Spiral Matrix",
"uuid": "c1abafcc-0d44-4fb5-afae-bff3ce2e1b39",
"practices": [],
"prerequisites": [],
"prerequisites": ["arrays", "for-loops", "conditionals"],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is my solution : https://exercism.org/tracks/javascript/exercises/spiral-matrix/solutions/TomPradat

Most solutions don't use switch conditionals so I didn't add it

@TomPradat TomPradat marked this pull request as ready for review October 27, 2022 21:19
Copy link
Member

@SleeplessByte SleeplessByte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've cross referenced your comments to the top community solutions and I agree. Thank you, this is a great addition.

@SleeplessByte SleeplessByte merged commit 3a42df2 into exercism:main Oct 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest Hacktoberfest issues! Everyone allowed <3 hacktoberfest-accepted Opt-in to hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants