-
-
Notifications
You must be signed in to change notification settings - Fork 616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add prerequisites for practice exercises #1964
Add prerequisites for practice exercises #1964
Conversation
Dear TomPradatThank you for contributing to the JavaScript track on Exercism! 💙
Dear Reviewer/Maintainer
Automated comment created by PR Commenter 🤖. |
"prerequisites": [ | ||
"strings", | ||
"arrays", | ||
"conditionals-switch", | ||
"for-loops" | ||
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is my solution : https://exercism.org/tracks/javascript/exercises/matching-brackets/solutions/TomPradat
I've seen many solutions with conditional switches and I prefer it to regexps ones. Also I've added arrays because I think this is good exercise for 'stack' type solutions
"prerequisites": [ | ||
"arrays", | ||
"strings", | ||
"errors", | ||
"classes", | ||
"conditionals", | ||
"array-transformations" | ||
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is my solution : https://exercism.org/tracks/javascript/exercises/series/solutions/TomPradat
"prerequisites": [ | ||
"arrays", | ||
"strings", | ||
"for-loops", | ||
"array-analysis", | ||
"template-strings" | ||
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is my solution : https://exercism.org/tracks/javascript/exercises/grep/solutions/TomPradat
@@ -922,7 +940,7 @@ | |||
"name": "Spiral Matrix", | |||
"uuid": "c1abafcc-0d44-4fb5-afae-bff3ce2e1b39", | |||
"practices": [], | |||
"prerequisites": [], | |||
"prerequisites": ["arrays", "for-loops", "conditionals"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is my solution : https://exercism.org/tracks/javascript/exercises/spiral-matrix/solutions/TomPradat
Most solutions don't use switch conditionals so I didn't add it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've cross referenced your comments to the top community solutions and I agree. Thank you, this is a great addition.
Could I please have an hacktoberfest label 🙏 ?
This solves 4 exercises in the issue #984