Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prerequisites for practice exercises #1468

Merged

Conversation

TomPradat
Copy link
Contributor

This PR is related to #983 , it will deal with the following exercises :

meetup

hamming

raindrops

nucleotide-count

In order to evaluate the prerequisites in the best way, I'm doing the exercise then I'm reviewing the exercise's proof of work and the submitted solutions.

@github-actions
Copy link
Contributor

Dear TomPradat

Thank you for contributing to the JavaScript track on Exercism! 💙
You will see some automated feedback below 🤖. It would be great if you can make sure your PR covers those points. This will save your reviewer some time and your change can be merged quicker.

  • ✍️ If your PR is not related to an existing issue (and is not self-explaining like a typo fix), please make sure the description explains why the change you made is necessary.

  • 🔤 If your PR fixes an easy to identify typo, if would be great if you could check for that typo in the whole repo. For example, if you found Unicdoe, use "replace all" in your editor (or command line magic) to fix it consistently.

Dear Reviewer/Maintainer

  • 📏 Make sure you set the appropriate x:size label for the PR. (This also works after merging, in case you forgot about it.)

  • 🔍 Don't be too nit-picky. If the PR is a clear improvement compared to the status quo, it should be approved as clear signal this is good to be merged even if the minor comments you might have are not addressed by the contributor. Further improvement ideas can be captured in issues (if important enough) and implemented via additional PRs.

  • 🤔 After reviewing the diff in the "Files changed" section, take a moment to think about whether there are changes missing from the diff. Does something need to be adjusted in other places so the code or content stays consistent?

Automated comment created by PR Commenter 🤖.

config.json Show resolved Hide resolved
config.json Outdated
Comment on lines 632 to 638
"prerequisites": [
"classes",
"array-transformation",
"objects",
"strings",
"template-strings"
],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like "strings" is a duplicate of "template-strings", but I'm not 100% sure about adding "template-strings" here, what do you think?

Copy link
Member

@junedev junedev Oct 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This exercise is a tough one to define. The proof file solution is not very good imo and the community solutions are full of awful solutions as well.

I digged around a bit and I would use something like this as guidance for the prerequisites: https://exercism.org/tracks/javascript/exercises/nucleotide-count/solutions/shybyte
but with two changes

  • instead of the spread operator (...) there could be a simple split
  • you need a template string instead of Object.values(...).join in the end because the order is not guaranteed otherwise

That would leave us with classes, objects, template-strings, array-loops, conditionals and errors as prerequisites. What do you think about that?

I think we don't need to list strings as well because template strings will always come after "strings" in the concept tree.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, I've done something similar myself: https://exercism.org/tracks/javascript/exercises/nucleotide-count/solutions/TomPradat

I'm wondering about conditionals though, it seems to me that 4 prerequisites are long enough. What's more, conditionals should be known before learning about objects. What do you think?

@TomPradat
Copy link
Contributor Author

TomPradat commented Oct 27, 2021

May I have a hacktoberfest-accepted label on this PR please ❤️

@junedev junedev added the hacktoberfest-accepted Opt-in to hacktoberfest label Oct 29, 2021
@TomPradat TomPradat marked this pull request as ready for review October 29, 2021 13:21
Copy link
Member

@junedev junedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left my thoughts on the exercises in the PR. The issue description also mentions "meetup". Not sure what's up with that. 🤔

config.json Show resolved Hide resolved
config.json Outdated Show resolved Hide resolved
config.json Outdated
Comment on lines 632 to 638
"prerequisites": [
"classes",
"array-transformation",
"objects",
"strings",
"template-strings"
],
Copy link
Member

@junedev junedev Oct 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This exercise is a tough one to define. The proof file solution is not very good imo and the community solutions are full of awful solutions as well.

I digged around a bit and I would use something like this as guidance for the prerequisites: https://exercism.org/tracks/javascript/exercises/nucleotide-count/solutions/shybyte
but with two changes

  • instead of the spread operator (...) there could be a simple split
  • you need a template string instead of Object.values(...).join in the end because the order is not guaranteed otherwise

That would leave us with classes, objects, template-strings, array-loops, conditionals and errors as prerequisites. What do you think about that?

I think we don't need to list strings as well because template strings will always come after "strings" in the concept tree.

config.json Outdated
@@ -629,7 +629,13 @@
"name": "Nucleotide Count",
"uuid": "be6f3ab3-1593-4c2d-8a35-5f39c1d5c91f",
"practices": [],
"prerequisites": [],
"prerequisites": [
"classes",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update: "classes" can be removed here, the exercise was changed to remove the unnecessary class definition (#1488)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant to create an issue about this, good to know it has been fixed :)

@TomPradat
Copy link
Contributor Author

Left my thoughts on the exercises in the PR. The issue description also mentions "meetup". Not sure what's up with that. thinking

Oops, looks like I forgot to push this one's commit. It's done now :)

@junedev junedev added the x:size/small Small amount of work label Nov 15, 2021
@junedev junedev merged commit 1d4faf9 into exercism:main Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Opt-in to hacktoberfest x:size/small Small amount of work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants