Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve concept exercise: Null and Undefined #1170

Merged
merged 22 commits into from
Jun 23, 2021
Merged

Improve concept exercise: Null and Undefined #1170

merged 22 commits into from
Jun 23, 2021

Conversation

junedev
Copy link
Member

@junedev junedev commented Jun 4, 2021 •
edited
Loading

Closes #1166

Notes

  • The first task does not practice anything specific to this concept but I felt some of the other tasks don't really make sense without it. Also it is a good "refresher" for objects.
  • For undefined I am quoting MDN because it is quite hard to express this correctly.
  • I assigned the "major" label because this was roughly the same amount of work as the other concept exercises I did since there was not much to build on. Not sure which of the new labels should be used instead.

@junedev junedev marked this pull request as ready for review June 13, 2021 18:51
@junedev junedev requested a review from a team June 13, 2021 18:51
@SleeplessByte SleeplessByte added x:size/l x:action/create Work on something from scratch x:module/concept Work on Concepts x:module/concept-exercise Work on Concept Exercises x:type/content Work on content (e.g. exercises, concepts) labels Jun 13, 2021
aimorris
aimorris reviewed Jun 13, 2021
View reviewed changes
Copy link
Contributor

@aimorris aimorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good other than some really minor punctuation and one consistency issue.

exercises/concept/amusement-park/.docs/instructions.md Outdated Show resolved Hide resolved
concepts/null-undefined/about.md Outdated Show resolved Hide resolved
exercises/concept/amusement-park/.docs/instructions.md Show resolved Hide resolved
@junedev
Copy link
Member Author

junedev commented Jun 14, 2021

@aimorris @bitboxx Thanks for the review! There is another concept exercise waiting for review for a while now. Would be great if you can have a look at that one as well in case you have some time. #1160

@github-actions github-actions bot removed the x:size/l label Jun 15, 2021
@junedev junedev requested a review from aimorris June 18, 2021 10:52
SleeplessByte
SleeplessByte approved these changes Jun 18, 2021
View reviewed changes
Copy link
Member

@SleeplessByte SleeplessByte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it a lot. See inline comments. Feel free to merge when ready.

concepts/null-undefined/about.md Show resolved Hide resolved
concepts/null-undefined/about.md Outdated Show resolved Hide resolved
concepts/null-undefined/about.md Outdated Show resolved Hide resolved
concepts/null-undefined/about.md Outdated Show resolved Hide resolved
concepts/null-undefined/about.md Outdated Show resolved Hide resolved
exercises/concept/amusement-park/.meta/design.md Show resolved Hide resolved
exercises/concept/amusement-park/amusement-park.js Outdated Show resolved Hide resolved
exercises/concept/amusement-park/amusement-park.js Outdated Show resolved Hide resolved
exercises/concept/amusement-park/amusement-park.js Outdated Show resolved Hide resolved
exercises/concept/amusement-park/amusement-park.spec.js Show resolved Hide resolved
tejasbubane
tejasbubane reviewed Jun 19, 2021
View reviewed changes
concepts/null-undefined/about.md Outdated Show resolved Hide resolved
concepts/null-undefined/about.md Show resolved Hide resolved
@junedev
Copy link
Member Author

junedev commented Jun 20, 2021

@SleeplessByte From my side this can be merged once objects was merged and the merge conflicts caused by that are resolved.

@SleeplessByte
Copy link
Member

Go for it. Looks good

@SleeplessByte SleeplessByte merged commit b307923 into exercism:main Jun 23, 2021
@junedev junedev deleted the improve-concept-exercise-null-undefined branch June 23, 2021 18:58
This was referenced Jul 14, 2022
Merged
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tejasbubane tejasbubane tejasbubane left review comments

@bitboxx bitboxx bitboxx approved these changes

@SleeplessByte SleeplessByte SleeplessByte approved these changes

@aimorris aimorris Awaiting requested review from aimorris

Assignees
No one assigned
Labels
x:action/create Work on something from scratch x:module/concept Work on Concepts x:module/concept-exercise Work on Concept Exercises x:size/large Large amount of work x:type/content Work on content (e.g. exercises, concepts)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[V3] Improve Concept Exercise: Null and Undefined
6 participants
@junedev @SleeplessByte @tejasbubane @aimorris @bitboxx @ErikSchierboom