Adding analyzer feedback for secrets concept exercise

[manumafe98]

pull request

closes #2685

This solution could be a great example to see if we want to ask the operator ~ to be used 100% or be flexible and only ask for the & one

Reviewer Resources:

Track Policies

[sanderploegsma]

@kahgoh you recently authored this exercise, do you have any suggestions to add or improve?

[kahgoh]

I think it looks good. I can't think of anything else to add or improve.

[manumafe98]

@kahgoh I don't think you could see the content of the link on the description of the PR, just in case I was referring to this

A student solve the exercise like this:

    public static int clearBits(int value, int mask) {
        int and = value & mask;
        return and ^ value;
    }

Instead of the most common solution, that would be like this:

    public static int clearBits(int value, int mask) {
        return value & ~mask ;
    }

Do you think we should allow it, or remark to use ~ in the analyzer?

[kahgoh]

@manumafe98 Sorry, I did miss the link in the PR's description. I think that is certainly a valid solution because it is still using bit operators, even though I didn't think of it when I created the exercise. From that perspective, I think if they use value & mask ^ value it should be allowed, although (if possible) we could suggest to try using & and ~ for a shorter solution.

[manumafe98]

@manumafe98 Sorry, I did miss the link in the PR's description. I think that is certainly a valid solution because it is still using bit operators, even though I didn't think of it when I created the exercise. From that perspective, I think if they use value & mask ^ value it should be allowed, although (if possible) we could suggest to try using & and ~ for a shorter solution.

Great, then I separated the ~ operator from the essential comment and I added an extra informative one.