Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add protein-translation exercise #52

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pfertyk
Copy link
Contributor

@pfertyk pfertyk commented Feb 18, 2024

No description provided.

@pfertyk pfertyk force-pushed the add-protein-translation-exercise branch 3 times, most recently from 8f8ff25 to 7636a9f Compare February 18, 2024 17:14
@pfertyk pfertyk marked this pull request as ready for review February 18, 2024 17:15
@pfertyk
Copy link
Contributor Author

pfertyk commented Feb 18, 2024

@BNAndras since there is an issue with the grains exercise, I decided to implement another one, until we solve that problem ;)

description = "Non-existing codon can't translate"

[9eac93f3-627a-4c90-8653-6d0a0595bc6f]
description = "Unknown amino acids, not part of a codon, can't translate"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should mark the tests not actually implemented by adding include = false underneath the description.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BNAndras done ;) I copied the tests from Python, I'm not sure why these ones were not included ... I've added a task for later to implement these missing tests, but I believe that can wait until after the track is public ;)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding some tests later means any previously submitted solutions will be rerun to see if they pass the full test suite. Depending on when you add those tests, there might not be too many solutions to rerun. On established popular tracks like Python, we could be rerunning thousands of submitted solutions every time we update the tests so I'd be careful about doing that long-term.

Marking tests as include = false means we have seen the tests but we won't implement them so configlet knows to ignore them when we run configlet sync. If you're still planning on implementing those tests, I'd instead remove the tests completely from the tests.toml. Then configlet sync will think we haven't synced to the latest tests and warn us that these additional tests need to be added or marked not included. That way, we won't forget in the future that some tests still need to be added.

@pfertyk pfertyk force-pushed the add-protein-translation-exercise branch from 7636a9f to cc9e01b Compare March 4, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants