-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: more occurrences of macos12 #890
base: main
Are you sure you want to change the base?
Conversation
Something is up with the nim installation on macOS and something else is happening with the windows tests in the nim scripts oO |
You should just rerun the Windows test. It's flaky |
Thanks, I will remember that. The MacOS tests are still not happy though |
Thanks, but I think we don't want the changes in this PR. The change from
Furthermore, it is likely that commit 22c4cec broke the I think we should close this in favor of #879. That is, we should move to the non-deprecated macOS x86_64 runner first. |
I did not consider the architecture change in the different os releases, thank you for that pointer. We should probably roll the changes back first and then move on with your suggestion. |
My apologies for stepping in without knowing the history and build status of this repo. |
Missed to files. Thanks @glennj