-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add exercise: allergies #97
Conversation
I have no idea why the armstrong-number tests are failing on windows. |
@exercism/cobol team: this PR introduces a new exercise, but it breaks the next exercise only on windows. Is there any kind of persistence between testing two consecutive exercises? Can someone investigate please? |
I expect it's because there is the need to INITIALIZE the result variable at the beginning of the solution. As I recall the test framework doesn't do that for you. |
Hi Bruce. My main difficulty is that it's a file I did not touch in this PR. How did it pass CI before this commit? |
git and I have a tenuous friendship. How do I download your PR so that I can access the code and tests? |
Good question. And I've been too busy for Exercism for a couple of months.
I'll have a look this week.
…On Mon, 19 Jun 2023 at 20:42, Glenn Jackman ***@***.***> wrote:
Hi Bruce. My main difficulty is that it's a file I did not touch in this
PR. How did it pass CI before this commit?
—
Reply to this email directly, view it on GitHub
<#97 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABTFVOE2BD3C5TDAZZ2M43XMBCKVANCNFSM6AAAAAAZB5YIS4>
.
You are receiving this because you are on a team that was mentioned.Message
ID: ***@***.***>
|
How do I get the source from the PR though? That's just the template. Belay that! I'm so long out of the flow that I'd forgotten about .meta and proof.ci.cob |
@exercism/cobol The windows tests for armstrong-numbers (not touched by this PR) continues to fail. If you want to participate in 12in23 next month, I strongly urge y'all to investigate. |
Can someone rerun the checks? I forked this repo, pulled in Glenn's branch and then manually ran the COBOL / Test (Windows) workflow. https://github.com/haodeon/cobol/actions/runs/5713644207/job/15479395675 They all passed and the whole workflow completed successfully. |
@glennj Could you fix the merge conflict? I'll merge once fixed |
Rework the initialization of the Allergens table according to "Beginning COBOL for Programmers", ch 11.
Thanks |
@glennj GnuCOBOL does have bit operations. E.g. https://gnucobol.sourceforge.io/faq/gcfaq.html#index-212 |
Responding to http://forum.exercism.org/t/select-featured-exercises-for-jurassic-july/6018/8
COBOL folks, please comment on idioms.
Includes a small improvement to the
bin/test
script to allow a single exercise to be verified.