Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add exercise: allergies #97

Merged
merged 3 commits into from
Aug 1, 2023
Merged

add exercise: allergies #97

merged 3 commits into from
Aug 1, 2023

Conversation

glennj
Copy link
Contributor

@glennj glennj commented Jun 10, 2023

Responding to http://forum.exercism.org/t/select-featured-exercises-for-jurassic-july/6018/8

COBOL folks, please comment on idioms.

Includes a small improvement to the bin/test script to allow a single exercise to be verified.

@glennj
Copy link
Contributor Author

glennj commented Jun 10, 2023

I have no idea why the armstrong-number tests are failing on windows.

@glennj
Copy link
Contributor Author

glennj commented Jun 13, 2023

@exercism/cobol team: this PR introduces a new exercise, but it breaks the next exercise only on windows. Is there any kind of persistence between testing two consecutive exercises? Can someone investigate please?

@axtens
Copy link
Member

axtens commented Jun 19, 2023

I expect it's because there is the need to INITIALIZE the result variable at the beginning of the solution. As I recall the test framework doesn't do that for you.

@glennj
Copy link
Contributor Author

glennj commented Jun 19, 2023

Hi Bruce. My main difficulty is that it's a file I did not touch in this PR. How did it pass CI before this commit?

@axtens
Copy link
Member

axtens commented Jun 19, 2023

git and I have a tenuous friendship. How do I download your PR so that I can access the code and tests?

@axtens
Copy link
Member

axtens commented Jun 19, 2023 via email

@axtens
Copy link
Member

axtens commented Jun 19, 2023

How do I get the source from the PR though? That's just the template.

Belay that! I'm so long out of the flow that I'd forgotten about .meta and proof.ci.cob

@glennj
Copy link
Contributor Author

glennj commented Jun 23, 2023

@exercism/cobol The windows tests for armstrong-numbers (not touched by this PR) continues to fail. If you want to participate in 12in23 next month, I strongly urge y'all to investigate.

@haodeon
Copy link

haodeon commented Jul 31, 2023

Can someone rerun the checks?

I forked this repo, pulled in Glenn's branch and then manually ran the COBOL / Test (Windows) workflow.

https://github.com/haodeon/cobol/actions/runs/5713644207/job/15479395675

They all passed and the whole workflow completed successfully.

@ErikSchierboom
Copy link
Member

@glennj Could you fix the merge conflict? I'll merge once fixed

Rework the initialization of the Allergens table according to "Beginning COBOL for Programmers", ch 11.
@ErikSchierboom ErikSchierboom merged commit 2a50271 into exercism:main Aug 1, 2023
3 checks passed
@ErikSchierboom
Copy link
Member

Thanks

@axtens
Copy link
Member

axtens commented Apr 6, 2024

@glennj GnuCOBOL does have bit operations. E.g. https://gnucobol.sourceforge.io/faq/gcfaq.html#index-212

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants