-
Notifications
You must be signed in to change notification settings - Fork 197
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #841 from executablebooks/agoose77/fix-pydata-sphi…
…nx-theme-update FIX: breaking style changes in pydata-sphinx-theme
- Loading branch information
Showing
10 changed files
with
23 additions
and
16 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -63,8 +63,9 @@ jobs: | |
pytest --durations=10 --cov=sphinx_book_theme --cov-report=xml --cov-report=term-missing | ||
# Only upload to codecov on pull requests so that we don't trigger rate limit blocks | ||
# Disabled for now with false && | ||
- name: Upload to Codecov | ||
if: matrix.os == 'ubuntu-latest' && matrix.python-version == 3.9 && matrix.sphinx == '~=7.0' && github.repository == 'executablebooks/sphinx-book-theme' && github.event_name == 'pull_request' | ||
if: false && matrix.os == 'ubuntu-latest' && matrix.python-version == 3.9 && matrix.sphinx == '~=7.0' && github.repository == 'executablebooks/sphinx-book-theme' && github.event_name == 'pull_request' | ||
uses: codecov/[email protected] | ||
with: | ||
name: ebp-sbt-pytests-py3.7 | ||
|
@@ -111,7 +112,7 @@ jobs: | |
text = Path("./warnings.txt").read_text().strip() | ||
expected_warning_patterns = [r"kitchen\-sink", r"urllib/parse\.py", r"Glyph 10024 .*? missing from current font"] | ||
print("\n=== Sphinx Warnings ===\n\n" + text) # Print just for reference so we can look at the logs | ||
unexpected = [l for l in text.splitlines() if not any(re.search(p, ii) for p in expected_warning_patterns)] | ||
unexpected = [l for l in text.splitlines() if not any(re.search(p, l) for p in expected_warning_patterns)] | ||
assert len(unexpected) == 0, unexpected | ||
- name: Audit with Lighthouse | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 2 additions & 2 deletions
4
src/sphinx_book_theme/theme/sphinx_book_theme/components/toggle-primary-sidebar.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
<label class="sidebar-toggle primary-toggle btn btn-sm" for="__primary" title="Toggle primary sidebar" data-bs-placement="bottom" data-bs-toggle="tooltip"> | ||
<button class="sidebar-toggle primary-toggle btn btn-sm" title="Toggle primary sidebar" data-bs-placement="bottom" data-bs-toggle="tooltip"> | ||
<span class="fa-solid fa-bars"></span> | ||
</label> | ||
</button> |
4 changes: 2 additions & 2 deletions
4
src/sphinx_book_theme/theme/sphinx_book_theme/components/toggle-secondary-sidebar.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
{# The in-page Table of Contents -#} | ||
{% set page_toc = generate_toc_html() -%} | ||
{% if page_toc -%} | ||
<label class="sidebar-toggle secondary-toggle btn btn-sm" for="__secondary"title="Toggle secondary sidebar" data-bs-placement="bottom" data-bs-toggle="tooltip"> | ||
<button class="sidebar-toggle secondary-toggle btn btn-sm" title="Toggle secondary sidebar" data-bs-placement="bottom" data-bs-toggle="tooltip"> | ||
<span class="fa-solid fa-list"></span> | ||
</label> | ||
</button> | ||
{%- endif %} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters