Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add release notes functionality #70

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

choldgraf
Copy link
Member

This is a work-in-progress to see how simple it would be to add release notes functionality to this package.

closes #69

Copy link

@stefanv stefanv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks @choldgraf! Do you use a custom script to generate reports from github-activity, or is there another tool for that?

if include_release_notes:
lines = description.split("\n")
headers = [ii.startswith("#") for ii in lines]
release_notes = [ii for ii in headers if "# release notes" in ii.lower()]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that this allows for subheadings and different capitalizations!

@choldgraf
Copy link
Member Author

Do you use a custom script to generate reports from github-activity

Could you explain more? I'm not sure what you mean. I usually just call this from the command line (cd myrepo; github-activity) and then copy-paste the markdown into either CHANGELOG.md or a GitHub release notes. I've found it is helpful to have that one final manual step to encourage some 👀 on the result.

@choldgraf choldgraf marked this pull request as ready for review July 31, 2022 19:05
@choldgraf
Copy link
Member Author

OK I think that this one should be ready to go. @stefanv or @tupui or @jarrodmillman want to try it out? See the docs for some light instructions

@stefanv
Copy link

stefanv commented Jul 31, 2022

The first issue I ran into is that github-activity needs the gh binary, but I don't see this requirement in the README or the docs.

@choldgraf
Copy link
Member Author

ooh good catch, it's not strictly required, only if you don't have a GITHUB_TOKEN passed already. That was added in:

So I think that's a bug

@stefanv
Copy link

stefanv commented Sep 27, 2022

@choldgraf At the skimage community call, we've been wondering how to use this functionality and also indicate categories for updates, such as API update, documentation, breaking changes, etc.

@choldgraf
Copy link
Member Author

I'm not sure when I'll have time to get to this - so I welcome anybody to make changes to this PR or make a new one to make it more useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include release notes from the pull request body in markdown output
2 participants