Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[buildkite] Add CI builds on GPUs #113

Merged
merged 13 commits into from
Nov 6, 2024
Merged

[buildkite] Add CI builds on GPUs #113

merged 13 commits into from
Nov 6, 2024

Conversation

amontoison
Copy link
Member

@sshin23
Copy link
Collaborator

sshin23 commented Nov 5, 2024

test-self-hosted can be commented out

using Pkg
Pkg.add("CUDA")
Pkg.add("KernelAbstractions")
Pkg.add("NLPModels")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why was this necessary?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It depends on how you want to run the tests.
If you just want to use runtests.jl, we can modify it.
But with the current pipeline.yml, we can also run specific and longer tests that target specific GPUs without environment variables.

I did something similar in Krylov.jl, using buildkite to run GPU tests separately from CPU tests, which is recommended to avoid occupying the GPUs for too long, allowing other users and repositories to access them.

Pkg.add("NLPModelsJuMP")
Pkg.add("Percival")
Pkg.add("PowerModels")
Pkg.add("MadNLP")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if this is ideal. Maybe we can create a separate Project.toml file for testing?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The best solution is to create one Project.toml for each dependency. We can create a CI build for each extension if we do that.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we do, say, Project.toml on /test and have Pkg.add("CUDA.jl") and Pkg.add("KernelAbstractions.jl") before project environment instantiation?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So that we don't need to keep duplicate copies of Project.toml for testing

Copy link
Member Author

@amontoison amontoison Nov 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this approach is good. Can we do it in this way?

@sshin23 sshin23 merged commit f002603 into main Nov 6, 2024
4 of 5 checks passed
@sshin23
Copy link
Collaborator

sshin23 commented Nov 6, 2024

Thanks @amontoison for setting this up!

@amontoison amontoison deleted the buildkite_ci branch November 6, 2024 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants