-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix header ordering, switch to meson #2
base: main
Are you sure you want to change the base?
Conversation
Changing the order of header includes has some side effects, for example signals ( |
As stated in the man pages, `sigaction` should be preferred to `signal`.
The kernel headers are supposed to be included after net/if.h, as they check whether net/if.h has been included before them, and if so, avoid redefinitions. This also avoid the non-portable hack of `#undef __USE_MISC`, which probably silently breaks glibc and leads to namespace pollution.
This allows for correctly checking for program presence, configuration and cross-compilation.
The header ordering probably isn't to blame; switching to sigaction, as recommended by the man pages, solved the problem. Rebased onto current master. |
Cherry-pick the first two into I will have to take a deeper look at the meson changes, not yet very familiar with it. |
I will prepare similar changes for signal handling in other projects. Do you want to be named as co-author there? |
No need to if I didn't write it. Thank you for being so considerate though :^)
As a quick introduction, make sure meson is installed.
This will perform some setup, warn about missing programs/dependencies, etc. This is ~equivalent to a
This builds the program and places the artifacts in the build directory. To install, you can use:
This installs the files, and this can be modified with Further than this basic example, meson allows for correct cross-compilation (if requested), subprojects, etc. As for the details of how the |
No description provided.