Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Everypolitician::Positions prototype #15608

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

chrismytton
Copy link
Contributor

What does this do?

This pull request is a prototype of an Everypolitician::Positions class for interacting with position data.

Why was this needed?

We want to add cabinet data to the term pages and in order to do this we need to interact with the position data from everypolitician-data. This data is currently in the unstable directory of each legislature, and therefore isn't available from the everypolitician gem yet.

Relevant Issue(s)

Implementation notes

I think I've actually got two changes going on here:

  • Adding classes for interacting with position data
  • Adding a class for getting position data from a CSV

So I think I probably want to end up with one pull request which adds the Position and Positions classes, and then a separate one that adds the UnstablePositionCSV class which can then return an instance of Positions. Then when we decide on where we want the CSVs to live we can just switch out UnstablePositionCSV for something else.

Notes to Merger

⚠️ Not ready for merging

This is ready for testing the `Legislature#positions` method I'm about
to add.
This is an initial stab at adding a positions method to
`Everypolitician::Legislature` instances.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants