Use tidy-html5 to validate the term-table page #15587
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this doesn't rebase cleanly with |
octopusinvitro
force-pushed
the
fix-closing-tag-term-table
branch
from
a1495ad
to
c3aa5cf
Compare
|
The title and description of this PR don't seem to match what's going on in it… |
octopusinvitro
force-pushed
the
fix-closing-tag-term-table
branch
from
c3aa5cf
to
82da917
Compare
octopusinvitro
changed the title
Errors corrected: - An "img" element must have an "alt" attribute, except under certain conditions. For details, consult guidance on providing text alternatives for images. (All occurrences)
octopusinvitro
force-pushed
the
fix-closing-tag-term-table
branch
from
82da917
to
42ebd9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
HTML-validates the term-table page and in doing so addresses this comments
Why was this needed?
HTML was broken
Relevant Issue(s)
everypolitician/everypolitician#505
Implementation notes
Validating the HTML (adding alt attributes to the images) required escaping the person names that go in those alt attributes, so a new method was added to the html helper.
Screenshots
None
Notes to Reviewer
Errors corrected:
conditions. For details, consult guidance on providing text alternatives
for images. (All occurrences)
Notes to Merger
None