Disallow useless string concatenation (#35)

eventjet · Jul 9, 2024 · 1ce8bfe · 1ce8bfe
1 parent 43b50e0
commit 1ce8bfe
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 1 deletion.
diff --git a/Eventjet/ruleset.xml b/Eventjet/ruleset.xml
@@ -83,13 +83,14 @@
     <!-- Forbid `$this` inside static function -->
     <rule ref="Squiz.Scope.StaticThisUsage"/>
 
-    <!-- Force whitespace before and after concatenation -->
+    <!-- String concatenation -->
     <rule ref="Squiz.Strings.ConcatenationSpacing">
         <properties>
             <property name="spacing" value="1"/>
             <property name="ignoreNewlines" value="true"/>
         </properties>
     </rule>
+    <rule ref="Generic.Strings.UnnecessaryStringConcat"/>
 
     <!-- Forbid spaces in type casts -->
     <rule ref="Squiz.WhiteSpace.CastSpacing"/>

diff --git a/php-cs-fixer-rules.php b/php-cs-fixer-rules.php
@@ -64,6 +64,7 @@
     'no_trailing_comma_in_singleline' => true,
     'no_unused_imports' => true,
     'no_useless_else' => true,
+    'no_useless_concat_operator' => true,
     'nullable_type_declaration_for_default_null_value' => true,
     'ordered_imports' => [
         'imports_order' => ['class', 'function', 'const'],

diff --git a/tests/fixtures/invalid/useless-concat.php b/tests/fixtures/invalid/useless-concat.php
@@ -0,0 +1,5 @@
+<?php
+
+declare(strict_types=1);
+
+echo 'a' . 'b';