Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement operators as functions #21

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Implement operators as functions #21

wants to merge 4 commits into from

Conversation

MidnightDesign
Copy link
Contributor

No description provided.

rieschl
rieschl previously approved these changes Mar 25, 2024
View reviewed changes
Copy link
Member

@rieschl rieschl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lots of bc breaks in there?

src/Eq.php Show resolved Hide resolved
@MidnightDesign
Copy link
Contributor Author

lots of bc breaks in there?

I was very deliberate when deciding what's @api and what's @internal originally. All of the removed classes were @internal ... except for Negative where I forgot to add it. : /

Widening the return types of the Expr::*() methods isn't ideal though. I should have never made them that narrow.

Let me think about how to proceed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rieschl rieschl rieschl left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MidnightDesign @rieschl