Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add labextensios for code quality #2

Draft
wants to merge 13 commits into
base: master
Choose a base branch
from
Draft

Conversation

Peter9192
Copy link
Member

@Peter9192 Peter9192 commented May 15, 2020

Add code quality extensions to jupyter lab environment

@Peter9192 Peter9192 changed the title Add labextension Add labextensios for code quality May 15, 2020
@Peter9192 Peter9192 removed the request for review from JaroCamphuijsen May 15, 2020 10:44
@Peter9192
Copy link
Member Author

I tried to add Jupyter lab code formatter, but it doesn't work due to a version mismatch (https://jupyterlab-code-formatter.readthedocs.io/en/latest/faq.html#version-mismatch-issue). Only thing that works now is isort, but the other's can be called from the terminal, hence I'd like to leave them in the environment.

Currently the limiting factor is Jupyterlab itself, which is at version 1.1.3. I think it would be nice to upgrade to jupyterlab 2.0, if possible. Perhaps that will resolve some of the problems here as well.

@Peter9192 Peter9192 marked this pull request as ready for review May 18, 2020 12:31
@Peter9192
Copy link
Member Author

@JaroCamphuijsen what do you think? Merge it like this or identify and solve problems with other code quality tools first? I'm afraid that will involve a major update, so rather postpone that till after we settled on an upgraded environment. In the mean time, users can still benefit from the code formatters from the shell that's available in jupyter lab.

- Inherit from newer jupyter/datascience-notebook
- Updated jupyter hub & jupyter lab versions
- Added explicit dependency of matplotlib
- Removed some packages as they are now part of base- or scipy-nb
- Removed some packages as they were installed as dependencies of others
- Moved all pip-installs to conda
- Add esmvalcore and esmvaltool-python
- Upgrade several packages to newer versions
- Disable not-working jupyter-thredds plugin
@Peter9192 Peter9192 marked this pull request as draft May 20, 2020 15:33
@Peter9192
Copy link
Member Author

I want to revisit this after #5 is merged.

@Peter9192
Copy link
Member Author

#5 is merged, but now the flake8 check has broken again, and jupyterlab-code-formatter still only works for isort (which is nice). Not sure how to proceed with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants