-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add labextensios for code quality #2
base: master
Are you sure you want to change the base?
Conversation
I tried to add Jupyter lab code formatter, but it doesn't work due to a version mismatch (https://jupyterlab-code-formatter.readthedocs.io/en/latest/faq.html#version-mismatch-issue). Only thing that works now is isort, but the other's can be called from the terminal, hence I'd like to leave them in the environment. Currently the limiting factor is Jupyterlab itself, which is at version 1.1.3. I think it would be nice to upgrade to jupyterlab 2.0, if possible. Perhaps that will resolve some of the problems here as well. |
@JaroCamphuijsen what do you think? Merge it like this or identify and solve problems with other code quality tools first? I'm afraid that will involve a major update, so rather postpone that till after we settled on an upgraded environment. In the mean time, users can still benefit from the code formatters from the shell that's available in jupyter lab. |
- Inherit from newer jupyter/datascience-notebook - Updated jupyter hub & jupyter lab versions - Added explicit dependency of matplotlib - Removed some packages as they are now part of base- or scipy-nb - Removed some packages as they were installed as dependencies of others - Moved all pip-installs to conda - Add esmvalcore and esmvaltool-python - Upgrade several packages to newer versions - Disable not-working jupyter-thredds plugin
I want to revisit this after #5 is merged. |
#5 is merged, but now the flake8 check has broken again, and jupyterlab-code-formatter still only works for isort (which is nice). Not sure how to proceed with this. |
Add code quality extensions to jupyter lab environment