Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify CMake order of operations #561

Merged
merged 3 commits into from
Jun 9, 2019
Merged

Modify CMake order of operations #561

merged 3 commits into from
Jun 9, 2019

Commits on Jun 5, 2019

  1. Modify cmake order of operations 

    It's important to add the source files after these options have been set, since lines executed in the "OS Specific Initialization" section affect what specific source files are included in the compilation. This commit updates that order.
    @jameskr97
    jameskr97 committed Jun 5, 2019
    Configuration menu
    Copy the full SHA
    576a6fa View commit details
    Browse the repository at this point in the history

  2. Load external libraries before linking

    @jameskr97
    jameskr97 committed Jun 5, 2019
    Configuration menu
    Copy the full SHA
    5fd590b View commit details
    Browse the repository at this point in the history

  3. Update ninja-build color options to be OS specific. 

    `-fcolor-diagnostics` is not universal, and will only work on Clang. This commit updates the passed compile flags depending on the compiler being used.
    @jameskr97
    jameskr97 committed Jun 5, 2019
    Configuration menu
    Copy the full SHA
    d2d08da View commit details
    Browse the repository at this point in the history