attempt to solve div/0 coverity defect with asserts

etternagame · May 20, 2020 · a29f1e6 · a29f1e6
1 parent f3e0bfa
commit a29f1e6
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/Etterna/Globals/MinaCalc.cpp b/src/Etterna/Globals/MinaCalc.cpp
@@ -12,6 +12,7 @@
 #include <unordered_set>
 #include <deque>
 #include <utility>
+#include <assert.h>
 
 using std::deque;
 using std::max;
@@ -229,7 +230,7 @@ chord_proportion(const vector<NoteInfo>& NoteInfo, const int chord_size)
 		if (notes == chord_size)
 			chords += notes;
 	}
-
+	assert(taps > 0);
 	return static_cast<float>(chords) / static_cast<float>(taps);
 }
 

diff --git a/src/Etterna/Models/NoteData/NoteData.cpp b/src/Etterna/Models/NoteData/NoteData.cpp
@@ -180,7 +180,7 @@ NoteData::WifeTotalScoreCalc(TimingData* td, int iStartIndex, int iEndIndex)
 			}
 		}
 	}
-
+	ASSERT(taps > 0);
 	return taps * 2;
 }