fix potential access violation in gettopchartscore

throw out index requests below 0 also fix a compile warn
etternagame · Jul 18, 2018 · 57dc187 · 57dc187
1 parent d8a7575
commit 57dc187
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/DownloadManager.cpp b/src/DownloadManager.cpp
@@ -1490,7 +1490,7 @@ class LunaDownloadManager : public Luna<DownloadManager>
 		string chartkey = SArg(1);
 		int rank = IArg(2);
 		int index = rank - 1;
-		if (!DLMAN->chartLeaderboards.count(chartkey) || index >= static_cast<int>(DLMAN->chartLeaderboards[chartkey].size())) {
+		if (index < 0 || !DLMAN->chartLeaderboards.count(chartkey) || index >= static_cast<int>(DLMAN->chartLeaderboards[chartkey].size())) {
 			lua_pushnil(L);
 			return 1;
 		}
@@ -1588,7 +1588,7 @@ class LunaDownloadManager : public Luna<DownloadManager>
 	{
 		auto bundle = DLMAN->GetCoreBundle(SArg(1));
 		lua_createtable(L, bundle.size(), 0);
-		for (int i = 0; i < bundle.size(); ++i) {
+		for (size_t i = 0; i < bundle.size(); ++i) {
 			bundle[i]->PushSelf(L);
 			lua_rawseti(L, -2, i + 1);
 		}