Fix a couple memory leaks

etternagame · Apr 2, 2018 · 08ee76e · 08ee76e
1 parent b7212d3
commit 08ee76e
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 6 deletions.
diff --git a/src/RageSurface_Load_XPM.cpp b/src/RageSurface_Load_XPM.cpp
@@ -77,7 +77,11 @@ RageSurface *RageSurface_Load_XPM( char * const *xpm, RString &error )
 
 	for( int y = 0; y < height; ++y )
 	{
-		CheckLine();
+		if (xpm[line] == NULL) {
+				error = "short file"; 
+				delete img;
+				return NULL; 
+		}
 		const RString row = xpm[line++];
 		if( (int) row.size() != width*color_length )
 		{

diff --git a/src/arch/LoadingWindow/LoadingWindow.cpp b/src/arch/LoadingWindow/LoadingWindow.cpp
@@ -21,20 +21,37 @@ LoadingWindow *LoadingWindow::Create()
 	RString Driver;
 	LoadingWindow *ret = NULL;
 
-	for( unsigned i = 0; ret == NULL && i < DriversToTry.size(); ++i )
+	for (unsigned i = 0; ret == NULL && i < DriversToTry.size(); ++i)
 	{
 		Driver = DriversToTry[i];
 
 #ifdef USE_LOADING_WINDOW_MACOSX
-		if( !DriversToTry[i].CompareNoCase("MacOSX") )	ret = new LoadingWindow_MacOSX;
+		if (!DriversToTry[i].CompareNoCase("MacOSX")) {
+			if (ret != nullptr)
+				delete ret;
+			ret = new LoadingWindow_MacOSX;
+		}
 #endif
 #ifdef USE_LOADING_WINDOW_GTK
-		if( !DriversToTry[i].CompareNoCase("Gtk") )	ret = new LoadingWindow_Gtk;
+		if (!DriversToTry[i].CompareNoCase("Gtk")) {
+			if (ret != nullptr)
+				delete ret;
+			ret = new LoadingWindow_Gtk;
+		}
 #endif
 #ifdef USE_LOADING_WINDOW_WIN32
-		if( !DriversToTry[i].CompareNoCase("Win32") )	ret = new LoadingWindow_Win32;
+		if (!DriversToTry[i].CompareNoCase("Win32")) {
+			if (ret != nullptr)
+				delete ret;
+			ret = new LoadingWindow_Win32;
+		}
+
 #endif
-		if( !DriversToTry[i].CompareNoCase("Null") )	ret = new LoadingWindow_Null;
+		if( !DriversToTry[i].CompareNoCase("Null") ) {
+			if (ret != nullptr)
+				delete ret;
+			ret = new LoadingWindow_Null;
+		}
 
 		if( ret == NULL )
 			continue;