Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make FillJacobianBlock public in ConstraintSet #49

Merged
merged 1 commit into from
Apr 17, 2020

Conversation

mpowelson
Copy link
Contributor

By allowing this to be externally callable, we are able to make costs and constraints that modify costs and constraints passed into them.

An example is the squared cost I made in order to address towr issue 72. The idea is that you can calculate any values you want as constraints and the pass them into this squared cost to convert them to into a squared cost. The issue was that I was only able to call the GetJacobian of the contained constraint which I would then have to decompose into the form that FillJacobianBlock needs. By exposing the constraint FillJacobianBlock, I can get only the pieces that the constraint I am modifying needs.

@mpowelson mpowelson force-pushed the feature/expose_fill_jac_block branch from de5455e to 96ee2db Compare April 17, 2020 19:13
@awinkler awinkler merged commit ee8b3fa into ethz-adrl:master Apr 17, 2020
@awinkler
Copy link
Member

Yes, that works, thanks for your help!

@mpowelson mpowelson deleted the feature/expose_fill_jac_block branch April 17, 2020 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants