-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make account type searchable #289
Open
hackmod
wants to merge
3
commits into
ethereumclassic:dev
Choose a base branch
from
EthersocialNetwork:search-account-type
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
make account type searchable #289
hackmod
wants to merge
3
commits into
ethereumclassic:dev
from
EthersocialNetwork:search-account-type
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hackmod
force-pushed
the
search-account-type
branch
from
March 16, 2019 19:08
156112d
to
aa68e32
Compare
wow, interesting. |
I don't think it is a good idea to define accounts and tokens on json, you should rather
|
Rebase your PR! |
ghost
mentioned this pull request
Apr 2, 2019
4 tasks
hackmod
force-pushed
the
search-account-type
branch
from
January 14, 2020 11:57
b4689d1
to
9394382
Compare
rebased |
kimisan
approved these changes
Jan 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tools/richlist.js
bug with a geth/parity style genesis.json$ node tools/richlist.js myaccounts.json
support searchable account like as
Account
orContract
or we can use user-defined account type like as follow.
user defined accounts could be inserted like as follow.