Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make account type searchable #289

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

hackmod
Copy link
Contributor

@hackmod hackmod commented Mar 16, 2019

  • fixed tools/richlist.js bug with a geth/parity style genesis.json
  • support partial accounts update with a given json file. (e.g) $ node tools/richlist.js myaccounts.json

support searchable account like as Account or Contract
image

or we can use user-defined account type like as follow.

        "genesisAddress": "predefined-addr.json",
        "accountTypes": {
            "1": "Exchanges", // saved as  (1<<3) | 0x4 (user-defined bit)
            "2": "Genesis Alloc" // saved as (2<<3) | 0x4
        },

user defined accounts could be inserted like as follow.

// predefined-addr.json
//...
  "0xfb8b7efb0xxxxxxxxxxxc0f0abc8c555684653587": {
    "type": 20 // 20 == (2 << 3) | 0x4
  },
  "0xfdbdaecxxxxxxxxxxxxxx18d94e0b8533f2801818": {
    "type": 20
  },
//...

@kimisan
Copy link
Member

kimisan commented Mar 16, 2019

wow, interesting.

@ghost
Copy link

ghost commented Mar 17, 2019

Conflicts with #288 @hackmod

@realcodywburns realcodywburns mentioned this pull request Mar 19, 2019
1 task
@ghost
Copy link

ghost commented Mar 22, 2019

I don't think it is a good idea to define accounts and tokens on json, you should rather

  1. implement them directly on db
  2. force users to customize their accounts

@ghost
Copy link

ghost commented Mar 25, 2019

Rebase your PR!

@hackmod
Copy link
Contributor Author

hackmod commented Jan 14, 2020

rebased

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants