fix: use default angelfood bootnodes if network is selected

[njgheorghita]

What was wrong?

fixes #1460

How was it fixed?

Added angelfood bootnodes and logic to handle the correct bootnodes depending on what network's selected.

To-Do

• Clean up commit history and use conventional commits.

[KolbyML]

I think it is weird to be able to use mainnet bootnodes on angelfood or the inverse. But I definitely think this PR is an big improvement on what we currently have.

[morph-dev]

I also don't like that there is "angelfood" as an option. Somebody can just call --bootnodes=angelfood and since mainnet is default network, this would not really work in practice.

In my opinion, "default" bootnodes would depend on the Network.
The way it would work is that instead of having impl From<Bootnodes> for Vec<Enr>, we would have:

impl Bootnodes {
    pub fn to_enrs(&self, network: Network) -> Vec<Enr> {
        let bootnodes: &Vec<Bootnode> = match (self, network) {
            (Bootnodes::Default, Network::Mainnet) => &DEFAULT_BOOTNODES,
            (Bootnodes::Default, Network::Angelfood) => &ANGELFOOD_BOOTNODES,
            (Bootnodes::None, _) => &vec![],
            (Bootnodes::Custom(bootnodes), _) => &bootnodes,
        };
        bootnodes.iter().map(|bn| bn.enr.clone()).collect()
    }
}

This breaks the PortalnetConfig, which doesn't have access the the network. To solve that problem, we can either:

• change PortalnetConfig.bootnodes to be Vec<Enr>, as all uses that I found are like:
  let bootnode_enrs: Vec<Enr> = portal_config.bootnodes.into();
• add network field to PortalnetConfig

I personally might have slight preference towards the first one.

If I missed something and it's not so simple, feel free to merge it as it is now.

[KolbyML]

I also don't like that there is "angelfood" as an option. Somebody can just call --bootnodes=angelfood and since mainnet is default network, this would not really work in practice.

In my opinion, "default" bootnodes would depend on the Network. The way it would work is that instead of having impl From<Bootnodes> for Vec<Enr>, we would have:

impl Bootnodes {
    pub fn to_enrs(&self, network: Network) -> Vec<Enr> {
        let bootnodes: &Vec<Bootnode> = match (self, network) {
            (Bootnodes::Default, Network::Mainnet) => &DEFAULT_BOOTNODES,
            (Bootnodes::Default, Network::Angelfood) => &ANGELFOOD_BOOTNODES,
            (Bootnodes::None, _) => &vec![],
            (Bootnodes::Custom(bootnodes), _) => &bootnodes,
        };
        bootnodes.iter().map(|bn| bn.enr.clone()).collect()
    }
}

This breaks the PortalnetConfig, which doesn't have access the the network. To solve that problem, we can either:

• change PortalnetConfig.bootnodes to be Vec<Enr>, as all uses that I found are like:
  let bootnode_enrs: Vec<Enr> = portal_config.bootnodes.into();
• add network field to PortalnetConfig

I personally might have slight preference towards the first one.

If I missed something and it's not so simple, feel free to merge it as it is now.

I really like this direction