Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): add workflow for unused dependencies #1430

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

DoTheBestToGetTheBest
Copy link

should closes #1418

@DoTheBestToGetTheBest DoTheBestToGetTheBest changed the title feat: add workflow for unused dependencies chore(ci): add workflow for unused dependencies Sep 8, 2024
@KolbyML KolbyML requested a review from carver September 8, 2024 21:12
@KolbyML
Copy link
Member

KolbyML commented Oct 3, 2024

@DoTheBestToGetTheBest sorry for the delay I will take over reviewing this PR.

Could you make udeps run on every PR like this example https://github.com/paradigmxyz/reth/blob/ab069979867087b72c1dfe24b535cd997b3b5f4b/.github/workflows/lint.yml#L133-L144

I know the original issue said make it once a week, but I think it makes sense to run it on every run like we do with our CI / commitlint CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Have a regular cargo-udeps check
2 participants