-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python 3.11 requirements #375
Conversation
1811461
to
43ce05f
Compare
6adcfa0
to
e9fb23d
Compare
I've changed all instances of this error to use a default_factory. This is due to this change in 3.11:
|
0ccba76
to
f6d05bf
Compare
I ran into this error (and similar ones) on Python 3.11 too:
I fixed it in my own fork before looking if there was a PR addressing it. Anyway, I came up with pretty much the same solution, except I used a lambda instead of the partial object and it seems to preserve more readability to me, see here . So just adding my 2 cents, consider using the lambda? Also, an unnecessary extra |
3c032a6
to
2f45e37
Compare
Your solution is way more elegant @eth2353 ! Thank you, adopted. |
a7df05b
to
dbff5e6
Compare
@holiman Can I pull you in for review? This changes requirements.txt and some of the code so it works with Python 3.11. |
Me??
Better leave this for @CarlBeek
|
68b1da5
to
09dcaf2
Compare
2cfe18c
to
a2dee51
Compare
04c265a
to
6674e7d
Compare
Updating cytoolz and toolz allows staking-deposit-cli to build with Python 3.11 / 3.12.
The hashes in this PR cover cytoolz on all architectures from Python 3.8 through Python 3.12. They were fetched with the helper script in #377 , with a minimum Python version of 3.8.
CI for Python 3.11 and 3.12 has been added, which required typed-ast to be removed from
requirements_test.txt
. As typed-ast is obsolete from Python 3.8, that should be fine.Closes #363