-
Notifications
You must be signed in to change notification settings - Fork 953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pinned contracts UX updated #5207
Conversation
✅ Deploy Preview for remixproject ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
1df9bd3
to
38f4c35
Compare
|
"udapp.deployedContracts": "Deployed/Unpinned Contracts", | ||
"udapp.deployAndRunClearInstances": "Clear instances list and reset recorder", | ||
"udapp.deployedContracts": "Deployed Contracts", | ||
"udapp.deployAndRunClearInstances": "Delete all deployed contracts (including pinned) and reset recorder", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the word Delete is not correct - I think it should be:
Clear all deployed contract...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Delete sounds like it will delete them from a public chain - if connected. Of course if the RemixVM is connected the word delete would be correct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
@@ -108,9 +108,9 @@ | |||
"udapp.tooltipText13": "Deployed {date}", | |||
|
|||
"udapp._comment_universalDappUI.tsx": "libs/remix-ui/run-tab/src/lib/components/universalDappUI.tsx", | |||
"udapp.tooltipTextRemove": "Remove from the list", | |||
"udapp.tooltipTextRemove": "Remove permanently from the list", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Permanently remove from this list
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
"udapp.tooltipTextEdit": "Create a DApp using this contract in the main panel", | ||
"udapp.tooltipTextPin": "Pin contract", | ||
"udapp.tooltipTextPin": "Pin contract for select workspace and network to persist after reload", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A pinned contract will be persisted after a browser refresh as long as the same Workspace and network are selected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this doesn't define the action of button and is more like a sentence. May be we can rephrase this
38035da
to
cf5abb7
Compare
cf5abb7
to
d57985c
Compare
fixes #5105