Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pinned contracts UX updated #5207

Merged
merged 16 commits into from
Sep 23, 2024
Merged

Pinned contracts UX updated #5207

merged 16 commits into from
Sep 23, 2024

Conversation

Aniket-Engg
Copy link
Collaborator

fixes #5105

Copy link

netlify bot commented Sep 18, 2024

Deploy Preview for remixproject ready!

Name Link
🔨 Latest commit d57985c
🔍 Latest deploy log https://app.netlify.com/sites/remixproject/deploys/66f1080d088d770008664230
😎 Deploy Preview https://deploy-preview-5207--remixproject.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@LianaHus
Copy link
Collaborator

  • contracts number should look like recorders recorded tx number
  • pin/unpin btns tooltip should have more explanations. @Aniket-Engg @ryestew

@Aniket-Engg Aniket-Engg added ready-to-review PR ready to review and removed WIP labels Sep 20, 2024
"udapp.deployedContracts": "Deployed/Unpinned Contracts",
"udapp.deployAndRunClearInstances": "Clear instances list and reset recorder",
"udapp.deployedContracts": "Deployed Contracts",
"udapp.deployAndRunClearInstances": "Delete all deployed contracts (including pinned) and reset recorder",
Copy link
Collaborator

@ryestew ryestew Sep 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the word Delete is not correct - I think it should be:
Clear all deployed contract...

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete sounds like it will delete them from a public chain - if connected. Of course if the RemixVM is connected the word delete would be correct.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@@ -108,9 +108,9 @@
"udapp.tooltipText13": "Deployed {date}",

"udapp._comment_universalDappUI.tsx": "libs/remix-ui/run-tab/src/lib/components/universalDappUI.tsx",
"udapp.tooltipTextRemove": "Remove from the list",
"udapp.tooltipTextRemove": "Remove permanently from the list",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Permanently remove from this list

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

"udapp.tooltipTextEdit": "Create a DApp using this contract in the main panel",
"udapp.tooltipTextPin": "Pin contract",
"udapp.tooltipTextPin": "Pin contract for select workspace and network to persist after reload",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A pinned contract will be persisted after a browser refresh as long as the same Workspace and network are selected.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesn't define the action of button and is more like a sentence. May be we can rephrase this

@Aniket-Engg Aniket-Engg merged commit b24a1a0 into master Sep 23, 2024
32 checks passed
@Aniket-Engg Aniket-Engg deleted the pinnedUI branch September 23, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-review PR ready to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UX: Pinned contracts view.
3 participants