fixing the link of learneth card in slider and adding matomo tracking #5201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for remixproject ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
yann300
reviewed
Sep 17, 2024
| await props.plugin.appManager.activatePlugin(['LearnEth', 'solidityUnitTesting']) | ||
| props.plugin.verticalIcons.select('LearnEth') | ||
| _paq.push(['trackEvent', 'hometab', 'featuredSection', 'LearnEth']) | ||
| await props.plugin.call('LearnEth', 'home') |
There was a problem hiding this comment.
ok i didn't know, there's a "home" funciton in learneth.
yann300
approved these changes
Sep 17, 2024
Aniket-Engg
requested changes
Sep 18, 2024
| await props.plugin.appManager.activatePlugin(['LearnEth', 'solidityUnitTesting']) | ||
| props.plugin.verticalIcons.select('LearnEth') | ||
| _paq.push(['trackEvent', 'hometab', 'featuredSection', 'LearnEth']) | ||
| await props.plugin.call('LearnEth', 'home') |
There was a problem hiding this comment.
I don't think home is a method for learneth. Clicking on button shows this error in browser console.
engine.ts:132 Uncaught (in promise) Error: Cannot call method "home" of "LearnEth" from "home", because "home" is not exposed. Here is the list of exposed methods: "startTutorial","addRepository","canDeactivate"
at RemixEngine.<anonymous> (engine.ts:132:13)
at Generator.next (<anonymous>)
at fulfilled (tslib.es6.js:73:43)
LianaHus
commented
Sep 18, 2024
| onClick={async () => { | ||
| await props.plugin.appManager.activatePlugin(['LearnEth', 'solidityUnitTesting']) | ||
| props.plugin.verticalIcons.select('LearnEth') | ||
| await props.plugin.call('LearnEth', 'home') |
There was a problem hiding this comment.
@yann300 @Aniket-Engg i omved it from here
Aniket-Engg
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.