Workspace selection fixes #5129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for remixproject ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
joeizang
force-pushed
the
workspace-selection-fixes
branch
from
cd89e1c
to
61f47eb
Compare
joeizang
force-pushed
the
workspace-selection-fixes
branch
2 times, most recently
from
8c065ce
to
6ad693b
Compare
Aniket-Engg
reviewed
Sep 2, 2024
| <Dropdown.Item | ||
| onClick={() => { | ||
| switchWorkspace(LOCALHOST) | ||
| }} | ||
| > | ||
| {currentWorkspace === LOCALHOST ? ( | ||
| <span>✓ localhost </span> | ||
| <span>✓ Connected to Local Filesystem </span> |
There was a problem hiding this comment.
Is this change discussed?
joeizang
force-pushed
the
workspace-selection-fixes
branch
2 times, most recently
from
6e4f0f3
to
2fda0e7
Compare
|
could you please put a divider before the Connect in hamburger? and also please remove -create workspace- from the dropdown |
Aniket-Engg
reviewed
Oct 7, 2024
Aniket-Engg
force-pushed
the
workspace-selection-fixes
branch
from
2e2f4de
to
da97ba2
Compare
Aniket-Engg
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4266