Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui bug fixed #5084

Closed
wants to merge 3 commits into from
Closed

ui bug fixed #5084

wants to merge 3 commits into from

Conversation

ijlal321
Copy link
Contributor

Hi, there was a text overlap in run tab section. Here is before and after.

Screenshot 2024-08-17 222825

After changing line Height

image

Note: Text overlap only happens when there is a contract deployed.

Let me know if need any further details or changes. Thanks

Copy link

netlify bot commented Aug 17, 2024

👷 Deploy request for remixproject pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 5a9c730

Copy link
Collaborator

@joeizang joeizang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice try. But you cannot make changes to the theme css file. That's like editing a bootstrap.min.css file. Can you find a better way?

@ijlal321
Copy link
Contributor Author

Nice try. But you cannot make changes to the theme css file. That's like editing a bootstrap.min.css file. Can you find a better way?

Thanks for clarification @joeizang. I have updated code.
let me know if you need anything else 👍

Copy link
Collaborator

@joeizang joeizang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better. But I think there should be a bootstrap class that can do this.

@ijlal321
Copy link
Contributor Author

ijlal321 commented Sep 6, 2024

Hi @joeizang.
So there is no way of doing this using Bootstrap, because I believe remix uses custom theme CSS files which are from Bootstrap4.

lh (line height class need to fix this bug) was introduced in bootstrap5.

Ofc we can make changes to theme css files to include lh class, but i think my last approach using CSS selector is much better.

Also I am new to all this, so I am extremely grateful for all the guidance you have provided in last messages. Thanks

@joeizang joeizang self-requested a review September 10, 2024 15:06
@Aniket-Engg
Copy link
Collaborator

As title is updated to Deployed Contracts. This is no more required. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants