tests, cmd/evm: expand --bench flag support to include statetest subcommand. introduce test name, fork, index filtering flags for state test subcommand.
#30442
+117
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwasinger
requested review from
holiman,
MariusVanDerWijden and
lightclient
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
evm statetest --benchis specified, benchmark the execution similarly toevm run. It will explicitly error if there is more than one matched subtest to be executed (newstatetestflags are added to filter which tests are ran).Breaks the state test runner API. But I figure that we are the only consumers of this API, so it's not a big problem?