ethclient: fix inconsistency between ethclient and WatchOpts #30438
+2
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
which is at accounts/abi/bind/base.go:85
xprotocol-bot
force-pushed
the
master
branch
from
acc6c67
to
376d283
Compare
|
Unsure we can change this, since it's API behavior. cc @fjl |
|
The mapping of |
|
Hey! So the issue was that for wss://base-sepolia-rpc.publicnode.com, they don't allow subscribing for more than 5000 blocks. So having genesis block as fromBlock parameter when watchOpts.Start is nil prevent me from using that RPC. On the another hand, if someone wants to query from genesis block, the person can query by setting fromBlock=new(big.Int).SetUint64(0). Maybe we need another filter to query for the last n blocks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to be consistent with accounts/abi/bind/base.go:85