Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Wrap usage of state transition API #1013

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chfast
Copy link
Member

@chfast chfast commented Sep 18, 2024

Wrap the usage of the state transition API from the evmone::state for tests so that the new API in evmone::test only exposes TestState and hides state::State.

This isolates usage of the evmone::state to lower the disturbance caused by API modifications,
e.g. in #802.

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 96.22642% with 2 lines in your changes missing coverage. Please review.

Project coverage is 93.99%. Comparing base (335d056) to head (03b5bf6).

Files with missing lines Patch % Lines
test/blockchaintest/blockchaintest_runner.cpp 88.88% 1 Missing ⚠️
test/t8n/t8n.cpp 87.50% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1013   +/-   ##
=======================================
  Coverage   93.98%   93.99%           
=======================================
  Files         147      147           
  Lines       15588    15596    +8     
=======================================
+ Hits        14651    14660    +9     
+ Misses        937      936    -1     
Flag Coverage Δ
eof_execution_spec_tests 17.61% <45.28%> (+0.06%) ⬆️
ethereum_tests 27.78% <47.16%> (+0.05%) ⬆️
ethereum_tests_silkpre 19.52% <25.00%> (+0.05%) ⬆️
execution_spec_tests 19.51% <47.16%> (+0.06%) ⬆️
unittests 88.98% <81.13%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
test/state/test_state.cpp 100.00% <100.00%> (ø)
test/state/test_state.hpp 80.00% <ø> (ø)
test/statetest/statetest_runner.cpp 96.66% <100.00%> (ø)
test/unittests/state_system_call_test.cpp 100.00% <100.00%> (ø)
test/unittests/state_transition.cpp 98.37% <100.00%> (+0.79%) ⬆️
test/blockchaintest/blockchaintest_runner.cpp 76.92% <88.88%> (-0.50%) ⬇️
test/t8n/t8n.cpp 86.80% <87.50%> (-0.10%) ⬇️

... and 1 file with indirect coverage changes

Wrap the usage of the state transition API from the `evmone::state`
for tests so that the new API in `evmone::test` only exposes
`TestState` and hides `state::State`.

This isolates usage of the `evmone::state` to lower the disturbance
caused by API modifications,
e.g. in #802.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant