Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add/fix imageUrl for upcoming events #13910

Merged
merged 1 commit into from
Sep 19, 2024
Merged

chore: add/fix imageUrl for upcoming events #13910

merged 1 commit into from
Sep 19, 2024

Conversation

wackerow
Copy link
Member

Description

  • Adds imageUrl for upcoming events

Demo'ing next 30:

image

Related Issue

@github-actions github-actions bot added the event 📅 This issue or pull request is related to an event listing label Sep 19, 2024
@netlify Netlify
Copy link

netlify bot commented Sep 19, 2024 •
edited
Loading

✅ Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit a355a8c
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/66ebceb28bf3c5000865db2a
😎 Deploy Preview https://deploy-preview-13910--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 7 paths audited
Performance: 42 (🔴 down 6 from production)
Accessibility: 93 (no change from production)
Best Practices: 89 (🔴 down 3 from production)
SEO: 92 (🔴 down 1 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@saurabhburade
Copy link
Contributor

Hi @wackerow, just popping up the issue #13851.

This happens if there is an issue with the image URL. There might be cases where assets are removed from these sites.

@corwintines corwintines merged commit 5963394 into staging Sep 19, 2024
6 checks passed
@corwintines corwintines deleted the staging-event-images branch September 19, 2024 14:52
This was referenced Oct 2, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corwintines corwintines corwintines approved these changes

@pettinarip pettinarip Awaiting requested review from pettinarip pettinarip is a code owner

@minimalsm minimalsm Awaiting requested review from minimalsm minimalsm is a code owner

Assignees
No one assigned
Labels
event 📅 This issue or pull request is related to an event listing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wackerow @saurabhburade @corwintines