Withdrawal address prompt #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valefar-on-discord
changed the title
|
Figured out the issue with the stalling test and I think this is good to go. |
remyroy
reviewed
Apr 30, 2024
| @@ -19,7 +19,7 @@ | |||
| }, | |||
| "arg_execution_address": { | |||
| "help": "The 20-byte (Eth1) execution address that will be used in withdrawal", | |||
| "prompt": "Please enter the 20-byte execution address for the new withdrawal credentials. Note that you CANNOT change it once you have set it on chain.", | |||
| "prompt": "Please enter the optional 20-byte execution address for the new withdrawal credentials. Note that you CANNOT change it once you have set it on chain.", | |||
There was a problem hiding this comment.
I would add something like this at the end of this message:
Please enter the optional 20-byte execution address for the new withdrawal credentials. Note that you CANNOT change it once you have set it on chain. Use a wallet address that you will have full control over for the foreseeable future.
What do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a prompt for withdrawal address when executing key generation.
There are a few changes of note:
defaultparam for the captive prompt. I simply don't see why not.closest_matchinintl.pycreates some pretty weird UX scenarios especially during language selection. As an example, if you provide1234as the option for language, it will chose12. My assumption this is used to avoid non-standard character match issues.#16