Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't pause or prompt for a key when running in non-interactive mode #173

Merged
merged 2 commits into from
Sep 28, 2024

Conversation

remyroy
Copy link
Member

@remyroy remyroy commented Sep 27, 2024

What I did

Run click.pause only when in interactive mode to make running the tool in non-interactive mode easier and smoother.

Related issue

Fixes #157 . Related to #170

@remyroy remyroy changed the title No pause2 Don't pause or prompt for a key when running in non-interactive mode Sep 27, 2024
Copy link

Test Coverage: Download HTML Report

Name                                                                 Stmts   Miss  Cover
----------------------------------------------------------------------------------------
ethstaker_deposit/__init__.py                                            1      0   100%
ethstaker_deposit/bls_to_execution_change_keystore.py                   33      2    94%
ethstaker_deposit/cli/__init__.py                                        0      0   100%
ethstaker_deposit/cli/existing_mnemonic.py                              42      0   100%
ethstaker_deposit/cli/exit_transaction_keystore.py                      43      3    93%
ethstaker_deposit/cli/exit_transaction_mnemonic.py                      65      9    86%
ethstaker_deposit/cli/generate_bls_to_execution_change.py               62     11    82%
ethstaker_deposit/cli/generate_bls_to_execution_change_keystore.py      44      3    93%
ethstaker_deposit/cli/generate_keys.py                                  44      2    95%
ethstaker_deposit/cli/new_mnemonic.py                                   32      0   100%
ethstaker_deposit/cli/partial_deposit.py                                64      5    92%
ethstaker_deposit/cli/test_keystore.py                                  22      1    95%
ethstaker_deposit/credentials.py                                       197     68    65%
ethstaker_deposit/deposit.py                                            58     10    83%
ethstaker_deposit/exceptions.py                                          7      0   100%
ethstaker_deposit/key_handling/__init__.py                               0      0   100%
ethstaker_deposit/key_handling/key_derivation/__init__.py                0      0   100%
ethstaker_deposit/key_handling/key_derivation/mnemonic.py               95      6    94%
ethstaker_deposit/key_handling/key_derivation/path.py                   17      1    94%
ethstaker_deposit/key_handling/key_derivation/tree.py                   36      0   100%
ethstaker_deposit/key_handling/keystore.py                             100      0   100%
ethstaker_deposit/settings.py                                           26      0   100%
ethstaker_deposit/utils/__init__.py                                      0      0   100%
ethstaker_deposit/utils/ascii_art.py                                     2      0   100%
ethstaker_deposit/utils/click.py                                        72      3    96%
ethstaker_deposit/utils/config.py                                        3      0   100%
ethstaker_deposit/utils/constants.py                                    29      0   100%
ethstaker_deposit/utils/crypto.py                                       29      1    97%
ethstaker_deposit/utils/deposit.py                                       9      0   100%
ethstaker_deposit/utils/exit_transaction.py                             24      0   100%
ethstaker_deposit/utils/file_handling.py                                 8      0   100%
ethstaker_deposit/utils/intl.py                                         54      3    94%
ethstaker_deposit/utils/ssz.py                                          60      7    88%
ethstaker_deposit/utils/terminal.py                                     28     20    29%
ethstaker_deposit/utils/validation.py                                  244     52    79%
----------------------------------------------------------------------------------------
TOTAL                                                                 1550    207    87%

Copy link
Collaborator

@valefar-on-discord valefar-on-discord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ezpz

@valefar-on-discord valefar-on-discord merged commit 76341d9 into eth-educators:main Sep 28, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't pause command when --non_interactive flag is used
2 participants