Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run lupdate on plugins too #869

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Run lupdate on plugins too #869

merged 1 commit into from
Jul 30, 2024

Conversation

10110111
Copy link
Contributor

This makes plugins translatable. The full command is:

lupdate src plugins -ts ./src/res/translations/edb_zh_CN.ts

This makes plugins translatable. The full command is:
lupdate src plugins -ts ./src/res/translations/edb_zh_CN.ts
@eteran
Copy link
Owner

eteran commented Jul 24, 2024

This definitely will work correctly for first party plugins. One thing we will probably need to consider is how 3rd party plugins interact with translations (if at all). Do we eventually allow translation files to be embedded in the plugin themselves so they can be loaded as well?

@10110111
Copy link
Contributor Author

Do we eventually allow translation files to be embedded in the plugin themselves so they can be loaded as well?

One way may be to query all the plugins for their own QTranslators and install them after (or before?) the app's ones. Not sure how this would work for conflicting strings translated differently.

@eteran
Copy link
Owner

eteran commented Jul 24, 2024

Yeah, something like this a good idea. We'll have to experiment with it.

@eteran
Copy link
Owner

eteran commented Jul 26, 2024

@10110111 are you thinking that this one should be merged too?

@10110111
Copy link
Contributor Author

I think it's a good start to get something at least all the stock GUI translatable. If you come up with a way to make external plugins translatable, this can be done in subsequent commits, with the strings being already present (assuming you get your translators to fill them in), just waiting for possible splitting.

@eteran
Copy link
Owner

eteran commented Jul 30, 2024

cool, i'll merge this in then :-)

Thanks as always!

@eteran eteran merged commit eedd97a into eteran:master Jul 30, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants