Merge pull request #71 from Dadoum/master

Add m_throw_on_unknown_critical to X509_cert
etcimon · Nov 2, 2023 · 5257ff4 · 5257ff4
2 parents 9ef9922 + a0c2066
commit 5257ff4
Showing 1 changed file with 10 additions and 5 deletions.
diff --git a/source/botan/cert/x509/x509cert.d b/source/botan/cert/x509/x509cert.d
@@ -498,8 +498,9 @@ public:
     * Params:
     *  input = the data source
     */
-    this(DataSource input)
+    this(DataSource input, bool throw_on_unknown_critical_ = true)
     {
+        m_throw_on_unknown_critical = throw_on_unknown_critical_;
         super(input, "CERTIFICATE/X509 CERTIFICATE");
         m_self_signed = false;
         doDecode();
@@ -512,22 +513,25 @@ public:
     * Params:
     *  filename = the name of the certificate file
     */
-    this(in string filename)
+    this(in string filename, bool throw_on_unknown_critical_ = true)
     {
+        m_throw_on_unknown_critical = throw_on_unknown_critical_;
         super(filename, "CERTIFICATE/X509 CERTIFICATE");
         m_self_signed = false;
         doDecode();
     }
 
-    this(ALLOC)(auto const ref Vector!(ubyte, ALLOC) input)
+    this(ALLOC)(auto const ref Vector!(ubyte, ALLOC) input, bool throw_on_unknown_critical_ = true)
     {
+        m_throw_on_unknown_critical = throw_on_unknown_critical_;
         super(input, "CERTIFICATE/X509 CERTIFICATE");
         m_self_signed = false;
         doDecode();
     }
 
-    this(ALLOC)(auto const ref RefCounted!(Vector!(ubyte, ALLOC), ALLOC) input)
+    this(ALLOC)(auto const ref RefCounted!(Vector!(ubyte, ALLOC), ALLOC) input, bool throw_on_unknown_critical_ = true)
     {
+        m_throw_on_unknown_critical = throw_on_unknown_critical_;
         super(input, "CERTIFICATE/X509 CERTIFICATE");
         m_self_signed = false;
         doDecode();
@@ -588,7 +592,7 @@ protected:
         if (v3_exts_data.type_tag == 3 &&
             v3_exts_data.class_tag == (ASN1Tag.CONSTRUCTED | ASN1Tag.CONTEXT_SPECIFIC))
         {
-            X509Extensions extensions = X509Extensions(true);
+            X509Extensions extensions = X509Extensions(m_throw_on_unknown_critical);
 
             BERDecoder(v3_exts_data.value).decode(extensions).verifyEnd();
 
@@ -632,6 +636,7 @@ protected:
 
     DataStore m_subject, m_issuer;
     bool m_self_signed;
+    bool m_throw_on_unknown_critical;
 }