Complete migration of verify workflow to prow #18058
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After recently addressing some issues impacting our
pull-etcd-verify
presubmit job in prow I believe the job is now performing as expected and we are now ready to proceed with completing the prow migration for this workflow by deleting the workflow file. This is process we will need to gradually repeat for other workflows over time.Refer the job summary in prow & testgrid:
Configuration for the prow job is here: https://github.com/kubernetes/test-infra/blob/master/config/jobs/etcd/etcd-presubmits.yaml#L53-L87
Note - As the first workflow to be fully migrated to prow this pr creates a new dependence on our use of
/ok-to-test
. I have updated some documentation to make this requirement clear but ultimately all @etcd-io/maintainers-etcd need to be vigilant that prow jobs have been triggered before merging a pr.Progress towards kubernetes/k8s.io#6102