Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete migration of verify workflow to prow #18058

Merged
merged 2 commits into from
May 23, 2024
Merged

Conversation

jmhbnz
Copy link
Member

@jmhbnz jmhbnz commented May 22, 2024

After recently addressing some issues impacting our pull-etcd-verify presubmit job in prow I believe the job is now performing as expected and we are now ready to proceed with completing the prow migration for this workflow by deleting the workflow file. This is process we will need to gradually repeat for other workflows over time.

Refer the job summary in prow & testgrid:

Configuration for the prow job is here: https://github.com/kubernetes/test-infra/blob/master/config/jobs/etcd/etcd-presubmits.yaml#L53-L87

Note - As the first workflow to be fully migrated to prow this pr creates a new dependence on our use of /ok-to-test. I have updated some documentation to make this requirement clear but ultimately all @etcd-io/maintainers-etcd need to be vigilant that prow jobs have been triggered before merging a pr.

Progress towards kubernetes/k8s.io#6102

@k8s-ci-robot k8s-ci-robot added area/documentation github_actions Pull requests that update GitHub Actions code labels May 22, 2024
Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We identified that the only check that's not working on the Prow infra is marker. I'll open an issue to find an alternative to it soon.

@ahrtr ahrtr merged commit 7a3ca53 into etcd-io:main May 23, 2024
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation area/tooling github_actions Pull requests that update GitHub Actions code
Development

Successfully merging this pull request may close these issues.

5 participants