Johnny/dp timeout #1720
Merged
Johnny/dp timeout #1720
+93
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jshearer
approved these changes
Oct 18, 2024
crates/gazette/src/lib.rs
Outdated
| let result = tokio::time::timeout(Duration::from_secs(10), async { | ||
| match ep.uri().scheme_str() { | ||
| Some("unix") => ep | ||
| .connect_with_connector(tower::util::service_fn(|uri: tonic::transport::Uri| { |
There was a problem hiding this comment.
Hah, I didn't even know this was supposed to be timing out at all -- I added a timeout in Dekaf for this as well.
psFried
force-pushed
the
johnny/dp-timeout
branch
from
be222e4
to
eef1422
Compare
Ensure we apply top-level timeouts to actions undertaken within a data-plane: - Staring a connector proxy environment. - Awaiting a connector unary response. - Activating built catalog specifications into a data-plane - Deleting built specifications from a data-plane. We want to preserve a firm boundary that data-planes are falliable and control-plane operations must protect themselves from an unavailability or undesired behavior of a data-plane.
jgraettinger
force-pushed
the
johnny/dp-timeout
branch
from
eef1422
to
d8e1394
Compare
jgraettinger
added
change:unplanned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wraps connector and gazette client dials in timeouts, since the
connect_timeoutgrpc options are insufficient to cover all cases that might block indefinitely. This is intended to fix issues with agents that stop making progress.This change is