-
Notifications
You must be signed in to change notification settings - Fork 51
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
go/runtime: journal watches used for mapping must use shard context
And not the task term context. The issue is that task term context is canceled when the term *begins* to change, but we allow the current transaction to complete, which means writing out documents, which means we may need to create a new physical partition and are not able to do that correctly if the journal watch is no longer updating. Instead, wrap the shard context with a cancel function and cancel prior watches at the start of the *next* task term.
- Loading branch information
1 parent
69765a6
commit 1c73ea6
Showing
2 changed files
with
21 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters